Skip to content

refactor: integrate util "noop" function in each packages #9125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

refactor: integrate util "noop" function in each packages #9125

wants to merge 12 commits into from

Conversation

novice0840
Copy link
Contributor

I integrated util function "noop". The function "noop" is already made in "query-core" package. So, we don't need to make again in "react-query" package

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e646812.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 58s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-12 11:42:50 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 8, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9125

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9125

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9125

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9125

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9125

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9125

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9125

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9125

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9125

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9125

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9125

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9125

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9125

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9125

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9125

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9125

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9125

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9125

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9125

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9125

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9125

commit: e646812

@codecov Codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.38%. Comparing base (c89c6a0) to head (e646812).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9125      +/-   ##
==========================================
- Coverage   44.40%   44.38%   -0.03%     
==========================================
  Files         206      202       -4     
  Lines        8174     8169       -5     
  Branches     1822     1828       +6     
==========================================
- Hits         3630     3626       -4     
+ Misses       4100     4099       -1     
  Partials      444      444
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.00% <ø> (-0.05%) ⬇️
@tanstack/eslint-plugin-query 83.02% <ø> (ø)
@tanstack/query-async-storage-persister 42.85% <ø> (-1.01%) ⬇️
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 96.38% <ø> (ø)
@tanstack/query-devtools 3.56% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 86.84% <ø> (+2.22%) ⬆️
@tanstack/query-test-utils 77.77% <ø> (ø)
@tanstack/react-query 95.34% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 77.49% <100.00%> (-0.08%) ⬇️
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.07% <ø> (-0.08%) ⬇️
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.85% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TkDodo
TkDodo reviewed Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the changes to package-lock, other than that, this should be good to be merged

pnpm-lock.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there shouldn’t be any changes in package-lock if there are no changes in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo left review comments

Assignees
No one assigned
Labels
package: angular-query-experimental package: query-async-storage-persister package: query-sync-storage-persister package: solid-query package: svelte-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novice0840 @TkDodo